Matt Van Horn
e7b7e61237
The plugin-contract test guards against references to the removed root-level scripts/ directory but matched any line containing "scripts/", which caught the new mcp/scripts/sync-engine.sh invocation in the release workflow. Extend the allowlist to cover mcp/scripts/ and make the structure explicit so future legitimate subdir scripts/ paths can be added without re-discovering this rule.
74 lines
2.8 KiB
Python
74 lines
2.8 KiB
Python
import json
|
|
import re
|
|
import tomllib
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[1]
|
|
SKILL_ROOT = ROOT / "skills" / "last30days"
|
|
|
|
|
|
def _json(path: Path) -> dict:
|
|
return json.loads(path.read_text(encoding="utf-8"))
|
|
|
|
|
|
def _skill_version() -> str:
|
|
text = (SKILL_ROOT / "SKILL.md").read_text(encoding="utf-8")
|
|
match = re.search(r'^version:\s*"([^"]+)"\s*$', text, re.MULTILINE)
|
|
if not match:
|
|
raise AssertionError("SKILL.md version frontmatter not found")
|
|
return match.group(1)
|
|
|
|
|
|
class TestPluginContract(unittest.TestCase):
|
|
def test_codex_plugin_scaffold_stays_removed(self) -> None:
|
|
# .codex-plugin/ was removed in the resolver-collapse refactor; Codex users
|
|
# install via `npx skills add` or `~/.codex/skills/`. A reintroduction would
|
|
# silently fork the install surface.
|
|
self.assertFalse((ROOT / ".codex-plugin").exists())
|
|
|
|
def test_versions_match_across_manifests(self) -> None:
|
|
pyproject = tomllib.loads((ROOT / "pyproject.toml").read_text(encoding="utf-8"))
|
|
version = pyproject["project"]["version"]
|
|
|
|
self.assertEqual(version, _skill_version())
|
|
self.assertEqual(version, _json(ROOT / ".claude-plugin" / "plugin.json")["version"])
|
|
|
|
marketplace = _json(ROOT / ".claude-plugin" / "marketplace.json")
|
|
plugins = marketplace.get("plugins") or []
|
|
self.assertEqual(1, len(plugins))
|
|
self.assertEqual(version, plugins[0]["version"])
|
|
|
|
def test_claude_marketplace_has_current_schema_shape(self) -> None:
|
|
marketplace = _json(ROOT / ".claude-plugin" / "marketplace.json")
|
|
|
|
self.assertNotIn("$schema", marketplace)
|
|
self.assertNotIn("description", marketplace)
|
|
self.assertIn("metadata", marketplace)
|
|
self.assertIn("description", marketplace["metadata"])
|
|
|
|
def test_workflows_do_not_reference_removed_root_scripts_dir(self) -> None:
|
|
# The root-level scripts/ directory was removed; workflows must not
|
|
# reference it. Subdirectory scripts/ paths (skills/last30days/scripts/
|
|
# for the Code-skill build, mcp/scripts/ for the .mcpb build) are
|
|
# the legitimate replacements.
|
|
allowed_prefixes = (
|
|
"skills/last30days/scripts/",
|
|
"mcp/scripts/",
|
|
)
|
|
offenders = []
|
|
for path in sorted((ROOT / ".github" / "workflows").glob("*.yml")):
|
|
for line_number, line in enumerate(path.read_text(encoding="utf-8").splitlines(), start=1):
|
|
if "scripts/" not in line:
|
|
continue
|
|
if any(prefix in line for prefix in allowed_prefixes):
|
|
continue
|
|
offenders.append(f"{path.relative_to(ROOT)}:{line_number}: {line.strip()}")
|
|
|
|
self.assertEqual([], offenders)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|