Trevin Chow
c913e1cf89
STEP 0 (CANONICAL PATH SELF-CHECK) used to force any SKILL.md load that wasn't
under $HOME/.claude/plugins/cache/last30days-skill/last30days/{version}/ to
re-Read from there. That guard is Claude-Code-specific (defends against the
marketplaces/ stale-clone bug) and broke under non-Claude installers like
`npx skills add`, ~/.codex/skills/, and ~/.agents/skills/.
The new STEP 0 narrows the check to its actual target: fire only when the
loaded SKILL.md path contains /.claude/plugins/marketplaces/. Every other
install path is trusted. The 2026-04-22 incident workaround is preserved
without breaking other harnesses.
Step 1 SKILL_ROOT resolver collapses the Codex-first / Claude-fallback /
CWD-fallback chain into a single precedence walk: Claude plugin cache
(versioned) first, then ~/.codex/skills, ~/.agents/skills, repo checkout,
./.skills/last30days (npx skills install dir), CWD, and GEMINI_EXTENSION_DIR.
Also drops Codex native plugin support: .codex-plugin/plugin.json is deleted,
the badge VERSION jq fallback in line 108 stops looking at it, and render.py's
_skill_version no longer scans for it. Codex users install via `npx skills add`
or the per-harness skill dir going forward.
render.py::_skill_version gains a SKILL.md frontmatter fallback so the badge
no longer emits `v?` on install dirs that sync.sh populates (which don't
include .claude-plugin/plugin.json).
57 lines
2.0 KiB
Python
57 lines
2.0 KiB
Python
import json
|
|
import re
|
|
import tomllib
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[1]
|
|
SKILL_ROOT = ROOT / "skills" / "last30days"
|
|
|
|
|
|
def _json(path: Path) -> dict:
|
|
return json.loads(path.read_text(encoding="utf-8"))
|
|
|
|
|
|
def _skill_version() -> str:
|
|
text = (SKILL_ROOT / "SKILL.md").read_text(encoding="utf-8")
|
|
match = re.search(r'^version:\s*"([^"]+)"\s*$', text, re.MULTILINE)
|
|
if not match:
|
|
raise AssertionError("SKILL.md version frontmatter not found")
|
|
return match.group(1)
|
|
|
|
|
|
class TestPluginContract(unittest.TestCase):
|
|
def test_versions_match_across_manifests(self) -> None:
|
|
pyproject = tomllib.loads((ROOT / "pyproject.toml").read_text(encoding="utf-8"))
|
|
version = pyproject["project"]["version"]
|
|
|
|
self.assertEqual(version, _skill_version())
|
|
self.assertEqual(version, _json(ROOT / ".claude-plugin" / "plugin.json")["version"])
|
|
|
|
marketplace = _json(ROOT / ".claude-plugin" / "marketplace.json")
|
|
plugins = marketplace.get("plugins") or []
|
|
self.assertEqual(1, len(plugins))
|
|
self.assertEqual(version, plugins[0]["version"])
|
|
|
|
def test_claude_marketplace_has_current_schema_shape(self) -> None:
|
|
marketplace = _json(ROOT / ".claude-plugin" / "marketplace.json")
|
|
|
|
self.assertNotIn("$schema", marketplace)
|
|
self.assertNotIn("description", marketplace)
|
|
self.assertIn("metadata", marketplace)
|
|
self.assertIn("description", marketplace["metadata"])
|
|
|
|
def test_workflows_do_not_reference_removed_root_scripts_dir(self) -> None:
|
|
offenders = []
|
|
for path in sorted((ROOT / ".github" / "workflows").glob("*.yml")):
|
|
for line_number, line in enumerate(path.read_text(encoding="utf-8").splitlines(), start=1):
|
|
if "scripts/" in line and "skills/last30days/scripts/" not in line:
|
|
offenders.append(f"{path.relative_to(ROOT)}:{line_number}: {line.strip()}")
|
|
|
|
self.assertEqual([], offenders)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|