红尘
d73ff9b0fb
Deploy Site / deploy-vercel (push) Has been cancelled
Deploy Site / deploy-docs (push) Has been cancelled
Docker / shell lint / Lint Dockerfile (hadolint) (push) Has been cancelled
Docker / shell lint / Lint docker/ shell scripts (shellcheck) (push) Has been cancelled
Docker Build and Publish / build-amd64 (push) Has been cancelled
Docker Build and Publish / build-arm64 (push) Has been cancelled
Lint (ruff + ty) / ruff + ty diff (push) Has been cancelled
Lint (ruff + ty) / ruff enforcement (blocking) (push) Has been cancelled
Lint (ruff + ty) / Windows footguns (blocking) (push) Has been cancelled
Nix Lockfile Fix / auto-fix-main (push) Has been cancelled
Nix Lockfile Fix / fix (push) Has been cancelled
Nix / nix (macos-latest) (push) Has been cancelled
Nix / nix (ubuntu-latest) (push) Has been cancelled
OSV-Scanner / Scan lockfiles (push) Has been cancelled
Build Skills Index / build-index (push) Has been cancelled
Tests / test (1) (push) Has been cancelled
Tests / test (2) (push) Has been cancelled
Tests / test (3) (push) Has been cancelled
Tests / test (4) (push) Has been cancelled
Tests / test (5) (push) Has been cancelled
Tests / test (6) (push) Has been cancelled
Tests / e2e (push) Has been cancelled
uv.lock check / uv lock --check (push) Has been cancelled
Docker Build and Publish / merge (push) Has been cancelled
Build Skills Index / trigger-deploy (push) Has been cancelled
Tests / save-durations (push) Has been cancelled
114 lines
3.5 KiB
Python
114 lines
3.5 KiB
Python
"""Regression guard for Feishu bot-sender authorization bypass.
|
|
|
|
Mirrors tests/gateway/test_discord_bot_auth_bypass.py for Platform.FEISHU.
|
|
Without the bypass in gateway/run.py, Feishu bot senders admitted by the
|
|
adapter would be rejected at _is_user_authorized with "Unauthorized user"
|
|
— same class of bug as Discord #4466.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from types import SimpleNamespace
|
|
|
|
import pytest
|
|
|
|
from gateway.session import Platform, SessionSource
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _isolate_feishu_env(monkeypatch):
|
|
for var in (
|
|
"FEISHU_ALLOW_BOTS",
|
|
"FEISHU_ALLOWED_USERS",
|
|
"FEISHU_ALLOW_ALL_USERS",
|
|
"GATEWAY_ALLOW_ALL_USERS",
|
|
"GATEWAY_ALLOWED_USERS",
|
|
):
|
|
monkeypatch.delenv(var, raising=False)
|
|
|
|
|
|
def _make_bare_runner():
|
|
from gateway.run import GatewayRunner
|
|
|
|
runner = object.__new__(GatewayRunner)
|
|
runner.pairing_store = SimpleNamespace(is_approved=lambda *_a, **_kw: False)
|
|
return runner
|
|
|
|
|
|
def _make_feishu_bot_source(open_id: str = "ou_peer"):
|
|
return SessionSource(
|
|
platform=Platform.FEISHU,
|
|
chat_id="oc_1",
|
|
chat_type="group",
|
|
user_id=open_id,
|
|
user_name="PeerBot",
|
|
is_bot=True,
|
|
)
|
|
|
|
|
|
def _make_feishu_human_source(open_id: str = "ou_human"):
|
|
return SessionSource(
|
|
platform=Platform.FEISHU,
|
|
chat_id="oc_1",
|
|
chat_type="group",
|
|
user_id=open_id,
|
|
user_name="Human",
|
|
is_bot=False,
|
|
)
|
|
|
|
|
|
def test_feishu_bot_authorized_when_allow_bots_mentions(monkeypatch):
|
|
runner = _make_bare_runner()
|
|
monkeypatch.setenv("FEISHU_ALLOW_BOTS", "mentions")
|
|
monkeypatch.setenv("FEISHU_ALLOWED_USERS", "ou_human")
|
|
|
|
assert runner._is_user_authorized(_make_feishu_bot_source("ou_peer")) is True
|
|
|
|
|
|
def test_feishu_bot_authorized_when_allow_bots_all(monkeypatch):
|
|
runner = _make_bare_runner()
|
|
monkeypatch.setenv("FEISHU_ALLOW_BOTS", "all")
|
|
monkeypatch.setenv("FEISHU_ALLOWED_USERS", "ou_human")
|
|
|
|
assert runner._is_user_authorized(_make_feishu_bot_source()) is True
|
|
|
|
|
|
def test_feishu_bot_NOT_authorized_when_allow_bots_none(monkeypatch):
|
|
runner = _make_bare_runner()
|
|
monkeypatch.setenv("FEISHU_ALLOW_BOTS", "none")
|
|
monkeypatch.setenv("FEISHU_ALLOWED_USERS", "ou_human")
|
|
|
|
assert runner._is_user_authorized(_make_feishu_bot_source("ou_peer")) is False
|
|
|
|
|
|
def test_feishu_bot_NOT_authorized_when_allow_bots_unset(monkeypatch):
|
|
runner = _make_bare_runner()
|
|
monkeypatch.setenv("FEISHU_ALLOWED_USERS", "ou_human")
|
|
|
|
assert runner._is_user_authorized(_make_feishu_bot_source("ou_peer")) is False
|
|
|
|
|
|
def test_feishu_human_still_checked_against_allowlist_when_bot_policy_set(monkeypatch):
|
|
"""FEISHU_ALLOW_BOTS=all must NOT open the gate for humans."""
|
|
runner = _make_bare_runner()
|
|
monkeypatch.setenv("FEISHU_ALLOW_BOTS", "all")
|
|
monkeypatch.setenv("FEISHU_ALLOWED_USERS", "ou_human")
|
|
|
|
assert runner._is_user_authorized(_make_feishu_human_source("ou_stranger")) is False
|
|
assert runner._is_user_authorized(_make_feishu_human_source("ou_human")) is True
|
|
|
|
|
|
def test_feishu_bot_bypass_does_not_leak_to_other_platforms(monkeypatch):
|
|
"""FEISHU_ALLOW_BOTS=all must not authorize Telegram/Discord bot sources."""
|
|
runner = _make_bare_runner()
|
|
monkeypatch.setenv("FEISHU_ALLOW_BOTS", "all")
|
|
|
|
telegram_bot = SessionSource(
|
|
platform=Platform.TELEGRAM,
|
|
chat_id="123",
|
|
chat_type="channel",
|
|
user_id="999",
|
|
is_bot=True,
|
|
)
|
|
assert runner._is_user_authorized(telegram_bot) is False
|