From e568ef8af94c8d93c941bdd7fd50c25346df088c Mon Sep 17 00:00:00 2001 From: Jeffrey Sperling Date: Wed, 11 Mar 2026 18:02:33 -0700 Subject: [PATCH] Revert MODEL_FALLBACK_ORDER to upstream values Model optimization (mini-first fallback, is_search_capable_model) belongs in PR #67. This PR stays focused on endpoint/API fixes only. Also fixes pre-existing test bug where test asserted gpt-4o was first in MODEL_FALLBACK_ORDER when it was actually gpt-4.1. --- scripts/lib/openai_reddit.py | 5 ++--- tests/test_openai_reddit.py | 12 ++++++------ 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/scripts/lib/openai_reddit.py b/scripts/lib/openai_reddit.py index d4e4a1e..f98e8e4 100644 --- a/scripts/lib/openai_reddit.py +++ b/scripts/lib/openai_reddit.py @@ -8,9 +8,8 @@ from typing import Any, Dict, List, Optional from . import http, env # Fallback models when the selected model isn't accessible (e.g., org not verified for GPT-5) -# gpt-5-mini: $0.25/1M input (8x cheaper than gpt-4.1), supports web_search with filters -# gpt-4o-mini does NOT support web_search with filters param, so exclude it -MODEL_FALLBACK_ORDER = ["gpt-5-mini", "gpt-4.1-mini", "gpt-4.1"] +# Note: gpt-4o-mini does NOT support web_search with filters param, so exclude it +MODEL_FALLBACK_ORDER = ["gpt-4.1", "gpt-4o"] def _log_error(msg: str): diff --git a/tests/test_openai_reddit.py b/tests/test_openai_reddit.py index 550fa9c..607be97 100644 --- a/tests/test_openai_reddit.py +++ b/tests/test_openai_reddit.py @@ -64,13 +64,13 @@ class TestIsModelAccessError(unittest.TestCase): class TestModelFallbackOrder(unittest.TestCase): """Tests for MODEL_FALLBACK_ORDER constant.""" - def test_contains_gpt41(self): - """Fallback list should include gpt-4.1 as last resort.""" - self.assertIn("gpt-4.1", MODEL_FALLBACK_ORDER) + def test_contains_gpt4o(self): + """Fallback list should include gpt-4o.""" + self.assertIn("gpt-4o", MODEL_FALLBACK_ORDER) - def test_gpt5_mini_is_first(self): - """gpt-5-mini should be the first fallback option (cheapest with web_search support).""" - self.assertEqual(MODEL_FALLBACK_ORDER[0], "gpt-5-mini") + def test_gpt41_is_first(self): + """gpt-4.1 should be the first fallback option.""" + self.assertEqual(MODEL_FALLBACK_ORDER[0], "gpt-4.1") if __name__ == "__main__":