refactor(github): resolve token once at pipeline boundary; pad no-token envelope

Greptile review (PR #438) flagged two issues:

1. search_github and enrich_with_comments both call _resolve_token,
   so when GITHUB_TOKEN is absent from config and env the gh-CLI
   subprocess (with its 5s timeout) fires twice per query.

2. The no-token early-return envelope `{"items": [], "error": "no token"}`
   was missing the `context` key that every other failure path includes,
   making the envelope shape inconsistent between the no-token and
   fetch-failure cases.

Fix 1: add public github.resolve_token(token) wrapping the existing
_resolve_token. Pipeline calls it once before search and enrich, so
both downstream calls receive an already-resolved (or already-None)
token and skip the fallback chain.

Fix 2: thread core/from_date/to_date/count through the no-token
envelope's `context` key, matching the fetch-failure envelope shape.
parse_github_response was already tolerant of the missing key, but
diagnostics callers that read response["context"]["..."] now get a
consistent dict in both error paths.

Reviewer's suggested code patch for issue 1 was a no-op (it kept the
same _resolve_token(token) call inside enrich_with_comments); the
underlying intent — resolve at the boundary — is what this commit
implements.
This commit is contained in:
Ilia Alshanetsky
2026-05-19 12:35:40 -04:00
parent 269dda9f6c
commit c5c0239dc9
3 changed files with 42 additions and 5 deletions
+23 -4
View File
@@ -62,6 +62,17 @@ def _resolve_token(token: Optional[str] = None) -> Optional[str]:
return None
def resolve_token(token: Optional[str] = None) -> Optional[str]:
"""Public alias for ``_resolve_token``.
The pipeline calls this once before ``search_github`` and
``enrich_with_comments`` so the ``gh auth token`` subprocess fallback
only fires once per query when ``GITHUB_TOKEN`` is unset, instead of
twice (once per call site).
"""
return _resolve_token(token)
def _fetch_json(
url: str,
token: Optional[str] = None,
@@ -161,13 +172,21 @@ def search_github(
Returns:
Dict envelope. Empty ``items`` list on any failure.
"""
count = DEPTH_LIMITS.get(depth, DEPTH_LIMITS["default"])
core = extract_core_subject(topic)
resolved_token = _resolve_token(token)
if not resolved_token:
_log("No GitHub token available (set GITHUB_TOKEN or install gh CLI)")
return {"items": [], "error": "no token"}
count = DEPTH_LIMITS.get(depth, DEPTH_LIMITS["default"])
core = extract_core_subject(topic)
return {
"items": [],
"error": "no token",
"context": {
"core": core,
"from_date": from_date,
"to_date": to_date,
"count": count,
},
}
_log(f"Searching for '{core}' (raw: '{topic}', since {from_date}, count={count})")
# Build search query with date filter