feat: vs mode N full passes + --competitors auto-discovery + (/Last30Days) title (#312)
* feat: vs mode runs N full passes; --competitors wraps vs with auto-discovery
Unifies vs-mode and --competitors onto one fanout architecture. A topic
containing "vs" / "versus" now runs N full pipeline.run() calls in parallel
(reverting the one-pass latency optimization that removed per-entity
depth); --competitors becomes a SKILL.md-level shortcut where the hosting
reasoning model (Claude Code, Codex, Hermes, Gemini) discovers N peers via
its own WebSearch, runs Step 0.55 per entity, and invokes the engine with
a vs-topic + --competitors-plan JSON.
Changed:
- vs-mode: N full passes in parallel via fanout (was 1 merged pass).
- --competitors: SKILL.md shortcut for vs-mode-with-discovery. Engine flag
kept for headless/cron use. LAW 7-style stderr reframed to lead with the
hosting-model path (use WebSearch + --competitors-plan) instead of
BRAVE_API_KEY. Footer BRAVE/SERPER nudge suppressed when --plan or
--competitors-plan present (hosting model already has WebSearch).
Added:
- --competitors-plan JSON flag: per-entity {x_handle, x_related, subreddits,
github_user, github_repos, context}. Accepts inline JSON or file path.
subrun_kwargs_for helper is the single source of truth for per-entity
kwargs — no closure-default fallthrough from main scope.
- Per-entity save files: each entity's sub-run produces its own
{slug}-raw.md with a single-row Resolved Entities block.
- --polymarket-keywords filter for ambiguous single-token topics.
Fixed:
- test_competitor_subrun_isolation regression suite locks in 3.0.12's
no-leak invariant (main flags do not inherit into peer sub-runs).
- Updates test_regression.py for the new comparison-mode payload shape.
Bumps plugin.json to 3.0.13. 1,219 tests passing.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: comparison title attribution — (Last 30 Days) → (/Last30Days)
User feedback on 3.0.13 dogfood runs (Kanye vs Drake, Mercer Island,
Figma): the comparison-mode synthesis title should attribute to the
slash command rather than restate the date range.
Three SKILL.md occurrences updated. Pure documentation change. Bumps to
3.0.14.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,63 @@
|
||||
# ruff: noqa: E402
|
||||
"""Tests for vs-mode routing into the competitor fanout.
|
||||
|
||||
A topic containing " vs " / " versus " triggers N-pass fanout (not the
|
||||
old single-pipeline comparison plan). Each entity gets its own full
|
||||
pipeline.run() with its own Step 0.55 targeting.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import io
|
||||
import sys
|
||||
import unittest
|
||||
from contextlib import redirect_stderr
|
||||
from pathlib import Path
|
||||
|
||||
REPO_ROOT = Path(__file__).resolve().parents[1]
|
||||
sys.path.insert(0, str(REPO_ROOT / "scripts"))
|
||||
|
||||
from lib import planner
|
||||
|
||||
|
||||
class VsModeEntityDetectionTests(unittest.TestCase):
|
||||
"""The planner's _comparison_entities helper is the detector we use."""
|
||||
|
||||
def test_two_entity_vs(self):
|
||||
self.assertEqual(
|
||||
planner._comparison_entities("OpenAI vs Anthropic"),
|
||||
["OpenAI", "Anthropic"],
|
||||
)
|
||||
|
||||
def test_three_entity_vs(self):
|
||||
self.assertEqual(
|
||||
planner._comparison_entities("Kanye West vs Drake vs Kendrick Lamar"),
|
||||
["Kanye West", "Drake", "Kendrick Lamar"],
|
||||
)
|
||||
|
||||
def test_versus_alt_spelling(self):
|
||||
result = planner._comparison_entities("A versus B")
|
||||
self.assertEqual(result, ["A", "B"])
|
||||
|
||||
def test_dotted_vs(self):
|
||||
result = planner._comparison_entities("A vs. B")
|
||||
self.assertEqual(result, ["A", "B"])
|
||||
|
||||
def test_no_vs_returns_empty(self):
|
||||
self.assertEqual(planner._comparison_entities("OpenAI"), [])
|
||||
|
||||
def test_trailing_vs_returns_empty_or_single(self):
|
||||
# "OpenAI vs" with nothing after — should not trigger vs-mode
|
||||
result = planner._comparison_entities("OpenAI vs")
|
||||
# _comparison_entities caps at _max_subqueries("comparison") and
|
||||
# requires >=2 parts. Single "OpenAI" with empty after vs -> []
|
||||
self.assertLess(len(result), 2)
|
||||
|
||||
def test_dedup_identical_entities(self):
|
||||
# Defense against silly input — two "Drake"s should collapse.
|
||||
result = planner._comparison_entities("Drake vs Drake")
|
||||
self.assertEqual(result, ["Drake"])
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
Reference in New Issue
Block a user