From 6c402f66b7e8347f06705bee9d96edb76acb3ba0 Mon Sep 17 00:00:00 2001 From: Jeffrey Sperling Date: Wed, 11 Mar 2026 15:45:42 -0700 Subject: [PATCH] Update plan to reflect single upstream PR strategy --- ...ctor-query-relevance-consolidation-plan.md | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/docs/plans/2026-03-11-refactor-query-relevance-consolidation-plan.md b/docs/plans/2026-03-11-refactor-query-relevance-consolidation-plan.md index e82d684..31f814c 100644 --- a/docs/plans/2026-03-11-refactor-query-relevance-consolidation-plan.md +++ b/docs/plans/2026-03-11-refactor-query-relevance-consolidation-plan.md @@ -1,16 +1,17 @@ # Search Pipeline: Query & Relevance Consolidation -## Strategy: Two-phase delivery +## Strategy: Single upstream PR -**Phase 1 — Upstream PR** (`refactor/query-relevance-consolidation` -> `mvanhorn/last30days-skill:main`) -Pure refactors and bug fixes anyone would want. No behavior changes. +**Branch**: `refactor/query-relevance-consolidation` -> `mvanhorn/last30days-skill:main` +**PR**: https://github.com/mvanhorn/last30days-skill/pull/65 -**Phase 2 — Fork-only** (`feat/search-quality` on `j-sperling/last30days-skill`) -Opinionated behavior changes: computed relevance scores, platform-specific query optimization, post-retrieval filtering. +All changes (refactors + behavior improvements) combined into one upstream PR. +Originally planned as two phases, but the search quality improvements are +broadly useful, not opinionated — merged into a single contribution. --- -## Phase 1: Upstream PR (refactors + bug fixes) +## Refactors (commits 1-5) ### Step 1: New `query.py` — shared query utilities - Consolidate 7 duplicated `_extract_core_subject()` (bird_x, reddit, youtube_yt, tiktok, instagram, bluesky, scrapecreators_x) into one parameterized function @@ -49,7 +50,7 @@ Opinionated behavior changes: computed relevance scores, platform-specific query --- -## Phase 2: Fork-only (behavior changes) +## Search quality improvements (commits 6-8) ### Step 4: Replace hardcoded relevance with computed scores - `bird_x.py:471` — `"relevance": 0.7` → `token_overlap_relevance(core_topic, text)` @@ -73,6 +74,10 @@ Opinionated behavior changes: computed relevance scores, platform-specific query --- +## Status: COMPLETE + +All 8 commits pushed to `refactor/query-relevance-consolidation`. PR #65 updated. + ## Verify ```bash