Merge pull request #207 from iliaal/refactor/reddit-http-helper

refactor(reddit): migrate to http.get(params=...) helper

tests/test_http_v3.py

@@ -41,3 +41,66 @@ class Test429RetryLimit(unittest.TestCase):
             http.request("GET", "http://example.com", retries=3)
 
         self.assertEqual(mock_urlopen.call_count, 3)
+
+
+def _mock_response(body: str = '{"ok": true}', status: int = 200):
+    resp = MagicMock()
+    resp.__enter__ = MagicMock(return_value=resp)
+    resp.__exit__ = MagicMock(return_value=False)
+    resp.read.return_value = body.encode("utf-8")
+    resp.status = status
+    return resp
+
+
+class TestParamsEncoding(unittest.TestCase):
+    """request() should urlencode the params dict into the URL."""
+
+    def _sent_url(self, mock_urlopen) -> str:
+        request_arg = mock_urlopen.call_args[0][0]
+        return request_arg.full_url
+
+    @patch("lib.http.urllib.request.urlopen")
+    def test_params_appended_to_url(self, mock_urlopen):
+        mock_urlopen.return_value = _mock_response()
+        http.get("https://api.example.com/search", params={"q": "test", "limit": 10})
+        sent_url = self._sent_url(mock_urlopen)
+        self.assertIn("q=test", sent_url)
+        self.assertIn("limit=10", sent_url)
+
+    @patch("lib.http.urllib.request.urlopen")
+    def test_params_appended_with_existing_query_string(self, mock_urlopen):
+        mock_urlopen.return_value = _mock_response()
+        http.get("https://api.example.com/search?api_key=secret", params={"q": "test"})
+        sent_url = self._sent_url(mock_urlopen)
+        self.assertTrue(sent_url.startswith("https://api.example.com/search?api_key=secret&"))
+        self.assertIn("q=test", sent_url)
+
+    @patch("lib.http.urllib.request.urlopen")
+    def test_none_values_dropped(self, mock_urlopen):
+        mock_urlopen.return_value = _mock_response()
+        http.get("https://api.example.com/search", params={"q": "test", "filter": None})
+        sent_url = self._sent_url(mock_urlopen)
+        self.assertIn("q=test", sent_url)
+        self.assertNotIn("filter", sent_url)
+
+    @patch("lib.http.urllib.request.urlopen")
+    def test_empty_params_leaves_url_unchanged(self, mock_urlopen):
+        mock_urlopen.return_value = _mock_response()
+        http.get("https://api.example.com/search", params={})
+        sent_url = self._sent_url(mock_urlopen)
+        self.assertEqual(sent_url, "https://api.example.com/search")
+
+    @patch("lib.http.urllib.request.urlopen")
+    def test_no_params_kwarg_leaves_url_unchanged(self, mock_urlopen):
+        mock_urlopen.return_value = _mock_response()
+        http.get("https://api.example.com/search")
+        sent_url = self._sent_url(mock_urlopen)
+        self.assertEqual(sent_url, "https://api.example.com/search")
+
+    @patch("lib.http.urllib.request.urlopen")
+    def test_int_and_bool_params_stringified(self, mock_urlopen):
+        mock_urlopen.return_value = _mock_response()
+        http.get("https://api.example.com/search", params={"count": 25, "raw": True})
+        sent_url = self._sent_url(mock_urlopen)
+        self.assertIn("count=25", sent_url)
+        self.assertIn("raw=True", sent_url)