sawz/last30days-skill
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #193 from tmchow/fix/evaluator-test-env-isolation

Browse Source 
fix(tests): isolate env in resolve_google_judge_api_key test
This commit is contained in:
Matt Van Horn
2026-04-09 21:06:42 -07:00
committed by GitHub
parent c09ca59747 5896c9582b
commit 101c4724f4
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_evaluator_v3.py
+5 -1
View File
@@ -1,4 +1,5 @@
import json import json
import os
import sys import sys
import tempfile import tempfile
import unittest import unittest
@@ -99,7 +100,10 @@ class EvaluatorV3Tests(unittest.TestCase):
def test_resolve_google_judge_api_key_prefers_google_key(self): def test_resolve_google_judge_api_key_prefers_google_key(self):
with mock.patch.dict("os.environ", {"GOOGLE_API_KEY": "google", "GEMINI_API_KEY": "gemini"}, clear=False): with mock.patch.dict("os.environ", {"GOOGLE_API_KEY": "google", "GEMINI_API_KEY": "gemini"}, clear=False):
self.assertEqual("google", evaluator.resolve_google_judge_api_key({})) self.assertEqual("google", evaluator.resolve_google_judge_api_key({}))
self.assertEqual("fallback", evaluator.resolve_google_judge_api_key({"GOOGLE_GENAI_API_KEY": "fallback"})) with mock.patch.dict("os.environ", {k: "" for k in ("GOOGLE_API_KEY", "GEMINI_API_KEY", "GOOGLE_GENAI_API_KEY")}, clear=False):
for k in ("GOOGLE_API_KEY", "GEMINI_API_KEY", "GOOGLE_GENAI_API_KEY"):
os.environ.pop(k, None)
self.assertEqual("fallback", evaluator.resolve_google_judge_api_key({"GOOGLE_GENAI_API_KEY": "fallback"}))
def test_extract_gemini_text_raises_when_missing(self): def test_extract_gemini_text_raises_when_missing(self):
self.assertEqual( self.assertEqual(